hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aihua Xu" <...@cloudera.com>
Subject Re: Review Request 35136: HIVE-10911 Add support for date datatype in the value based windowing function
Date Fri, 05 Jun 2015 20:44:42 GMT


> On June 5, 2015, 6:22 p.m., Ashutosh Chauhan wrote:
> > data/files/emp2.txt, line 1
> > <https://reviews.apache.org/r/35136/diff/1/?file=979976#file979976line1>
> >
> >     Can you add few rows with NULL value for date column? Want to make sure  DateValueBoundaryScanner.isGreater()
and isEqual() methods are null resilient.

Added the support to deal with NULL date. Compared to Oracle DB, since HIVE puts NULL date
rows first while Oracle puts in the last, there are some differences for some windowing. But
seems both are OK.


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35136/#review86824
-----------------------------------------------------------


On June 5, 2015, 8:42 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35136/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 8:42 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-10911 Add support for date datatype in the value based windowing function
> 
> 
> Diffs
> -----
> 
>   data/files/emp2.txt PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java c1b8a1d 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 40fd6a4 
>   ql/src/test/queries/clientpositive/windowing_windowspec3.q PRE-CREATION 
>   ql/src/test/results/clientpositive/windowing_windowspec3.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35136/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message