Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A98DA186FF for ; Fri, 29 May 2015 21:29:57 +0000 (UTC) Received: (qmail 52904 invoked by uid 500); 29 May 2015 21:29:57 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 52845 invoked by uid 500); 29 May 2015 21:29:57 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 52828 invoked by uid 99); 29 May 2015 21:29:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 May 2015 21:29:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6B9D11DDCAE; Fri, 29 May 2015 21:29:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8023946223198555413==" MIME-Version: 1.0 Subject: Re: Review Request 34727: HIVE-10835: Concurrency issues in JDBC driver From: "Chaoyu Tang" To: "Szehon Ho" , "Xuefu Zhang" , "Thejas Nair" Cc: "hive" , "Chaoyu Tang" , "Vaibhav Gumashta" Date: Fri, 29 May 2015 21:29:55 -0000 Message-ID: <20150529212955.8664.80970@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chaoyu Tang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/34727/ X-Sender: "Chaoyu Tang" References: <20150529195134.9497.95314@reviews.apache.org> In-Reply-To: <20150529195134.9497.95314@reviews.apache.org> Reply-To: "Chaoyu Tang" X-ReviewRequest-Repository: hive-git --===============8023946223198555413== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On May 29, 2015, 7:51 p.m., Vaibhav Gumashta wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java, line 126 > > > > > > Test looks good. Can you also add a Statement#cancel in the mix? Vaibhav, thanks for review. There is already a case testCancel provided in HIVE-6472. Do you want to incorporate the same (similar one) into the test of this patch? or could you elaborate more? - Chaoyu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34727/#review85782 ----------------------------------------------------------- On May 29, 2015, 11:44 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34727/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 11:44 a.m.) > > > Review request for hive, Szehon Ho, Thejas Nair, and Xuefu Zhang. > > > Bugs: HIVE-10835 > https://issues.apache.org/jira/browse/HIVE-10835 > > > Repository: hive-git > > > Description > ------- > > There exist race conditions between DatabaseMetaData, Statement and ResultSet when they make RPC calls to HS2 using same Thrift transport, which happens within same connection. > The patch is to have a connection level lock to serialize the RPC calls within a single connection. > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java 7210480 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1b2891b > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java e93795a > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java 6b3d05c > > Diff: https://reviews.apache.org/r/34727/diff/ > > > Testing > ------- > > Some multi-thread tests (80 threads for 200 iterations) > > > Thanks, > > Chaoyu Tang > > --===============8023946223198555413==--