Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8A7AB18A5C for ; Thu, 21 May 2015 07:18:01 +0000 (UTC) Received: (qmail 49702 invoked by uid 500); 21 May 2015 07:18:00 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 49633 invoked by uid 500); 21 May 2015 07:18:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 49154 invoked by uid 99); 21 May 2015 07:18:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 May 2015 07:18:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 21F091C0160; Thu, 21 May 2015 07:18:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2645900100789114976==" MIME-Version: 1.0 Subject: Re: Review Request 34393: HIVE-10427 - collect_list() and collect_set() should accept struct types as argument From: "Lenni Kuff" To: "hive" , "Chao Sun" , "Lenni Kuff" Date: Thu, 21 May 2015 07:18:00 -0000 Message-ID: <20150521071800.17212.12748@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Lenni Kuff" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/34393/ X-Sender: "Lenni Kuff" References: <20150521064457.17474.32171@reviews.apache.org> In-Reply-To: <20150521064457.17474.32171@reviews.apache.org> Reply-To: "Lenni Kuff" X-ReviewRequest-Repository: hive-git --===============2645900100789114976== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34393/#review84669 ----------------------------------------------------------- Ship it! lgtm - I assume this works with decimal (with scale/precision) and char/varchar? Maybe add one test case for those? - Lenni Kuff On May 21, 2015, 6:44 a.m., Chao Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34393/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 6:44 a.m.) > > > Review request for hive. > > > Bugs: HIVE-10427 > https://issues.apache.org/jira/browse/HIVE-10427 > > > Repository: hive-git > > > Description > ------- > > Currently for collect_list() and collect_set(), only primitive types are supported. This patch adds support for struct, list and map types as well. > > It turned out I that all I need is loosen the type checking. > > > Diffs > ----- > > data/files/customers.txt PRE-CREATION > data/files/nested_orders.txt PRE-CREATION > data/files/orders.txt PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java 536c4a7 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java 6dc424a > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java efcc8f5 > ql/src/test/queries/clientnegative/udaf_collect_set_unsupported.q PRE-CREATION > ql/src/test/queries/clientpositive/udaf_collect_set_2.q PRE-CREATION > ql/src/test/results/clientnegative/udaf_collect_set_unsupported.q.out PRE-CREATION > ql/src/test/results/clientpositive/udaf_collect_set_2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/34393/diff/ > > > Testing > ------- > > All but one test (which seems unrelated) are passing. > I also added a test: udaf_collect_list_set_2.q > > > Thanks, > > Chao Sun > > --===============2645900100789114976==--