Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 162D518A4A for ; Thu, 14 May 2015 06:39:53 +0000 (UTC) Received: (qmail 4063 invoked by uid 500); 14 May 2015 06:39:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3990 invoked by uid 500); 14 May 2015 06:39:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3970 invoked by uid 99); 14 May 2015 06:39:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 06:39:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 280931CC031; Thu, 14 May 2015 06:39:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4785593127420974072==" MIME-Version: 1.0 Subject: Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality From: "Alexander Pivovarov" To: "Xuefu Zhang" Cc: "Alexander Pivovarov" , "cheng xu" , "hive" Date: Thu, 14 May 2015 06:39:52 -0000 Message-ID: <20150514063952.1460.98327@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Pivovarov" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/33881/ X-Sender: "Alexander Pivovarov" References: <20150514055155.1461.20449@reviews.apache.org> In-Reply-To: <20150514055155.1461.20449@reviews.apache.org> Reply-To: "Alexander Pivovarov" X-ReviewRequest-Repository: hive-git --===============4785593127420974072== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33881/#review83724 ----------------------------------------------------------- beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java You can use IOUtils.closeQuietly(bw) I do not think we need to log close buffer error - Alexander Pivovarov On May 14, 2015, 5:51 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33881/ > ----------------------------------------------------------- > > (Updated May 14, 2015, 5:51 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-10623 > https://issues.apache.org/jira/browse/HIVE-10623 > > > Repository: hive-git > > > Description > ------- > > Changes: > 1. Support the hive cli options including database, e, !, H, f. > 2. Add error handler for using f and e together > 3. Add error handler for invalid option > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 0da15f6 > beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java PRE-CREATION > beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION > beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION > beeline/src/test/resources/hive-site.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/33881/diff/ > > > Testing > ------- > > Newly add unit test passed locally. > > > Thanks, > > cheng xu > > --===============4785593127420974072==--