hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "pengcheng xiong" <pxi...@hortonworks.com>
Subject Re: Review Request 34754: NumberFormatException while running analyze table partition compute statics query
Date Thu, 28 May 2015 18:22:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34754/#review85589
-----------------------------------------------------------


The patch looks generally good to me. One minor comment: it seems that the new change L403
in StatsUtils.java "partCS.setRange(getRangePartitionColumn(partList.getPartitions(), ci.getInternalName(),
                ci.getType().getTypeName(), conf.getVar(ConfVars.DEFAULTPARTITIONNAME)));"
will only be called when "referencedColumns.size() > neededColumns.size()" However, there
is no test cases that can cover that. I would suggest add the following test query "explain
select count(a), count(c), count(d), count(dt) from stats_null_part;" so that we can have
this path covered. Thanks.

- pengcheng xiong


On May 28, 2015, 4:03 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34754/
> -----------------------------------------------------------
> 
> (Updated May 28, 2015, 4:03 a.m.)
> 
> 
> Review request for hive and pengcheng xiong.
> 
> 
> Bugs: HIVE-10840
>     https://issues.apache.org/jira/browse/HIVE-10840
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> NumberFormatException while running analyze table partition compute statics query
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties ae03283 
>   ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ad481bc 
>   ql/src/test/queries/clientpositive/stats_only_null.q a91022c 
>   ql/src/test/results/clientpositive/tez/stats_only_null.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34754/diff/
> 
> 
> Testing
> -------
> 
> Modified existing test to increase its coverage.
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message