hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <chao....@cloudera.com>
Subject Re: Review Request 34393: HIVE-10427 - collect_list() and collect_set() should accept struct types as argument
Date Thu, 21 May 2015 06:44:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34393/
-----------------------------------------------------------

(Updated May 21, 2015, 6:44 a.m.)


Review request for hive.


Changes
-------

Addressing RB comments.


Bugs: HIVE-10427
    https://issues.apache.org/jira/browse/HIVE-10427


Repository: hive-git


Description
-------

Currently for collect_list() and collect_set(), only primitive types are supported. This patch
adds support for struct and map types as well.

It turned out I that all I need is loosen the type checking.


Diffs (updated)
-----

  data/files/customers.txt PRE-CREATION 
  data/files/nested_orders.txt PRE-CREATION 
  data/files/orders.txt PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectList.java 536c4a7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFCollectSet.java 6dc424a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFMkCollectionEvaluator.java
efcc8f5 
  ql/src/test/queries/clientnegative/udaf_collect_set_unsupported.q PRE-CREATION 
  ql/src/test/queries/clientpositive/udaf_collect_set_2.q PRE-CREATION 
  ql/src/test/results/clientnegative/udaf_collect_set_unsupported.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/udaf_collect_set_2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/34393/diff/


Testing
-------

All but one test (which seems unrelated) are passing.
I also added a test: udaf_collect_list_set_nested.q


Thanks,

Chao Sun


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message