hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan" <>
Subject Review Request 34495: HIVE-10678 : In QTestGenTask.execute() we should not throw an exception right away if we are unable to clean any old files
Date Wed, 20 May 2015 20:12:05 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for hive.

Repository: hive-git


Currently in QTestGenTask.execute(), we have code like :
       if (logFile != null) {
         File lf = new File(logFile);
         if (lf.exists()) {
           if (!lf.delete()) {
             throw new Exception("Could not delete log file " + lf.getCanonicalPath());
If the log file gets locked due to some other process, it throws the above exception and short
circuits the entire test suite. We should provide a mechanism to generate alternative new
log files/temporary files whenever possible to avoid unit test failures.


  ant/src/org/apache/hadoop/hive/ant/ 60c7764 




Hari Sankar Sivarama Subramaniyan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message