hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "cheng xu" <cheng.a...@intel.com>
Subject Re: Review Request 34235: HIVE-10687 Fix avro deserialization issues for evolved unions
Date Fri, 15 May 2015 02:06:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34235/#review83883
-----------------------------------------------------------



serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134958>

    tail space



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134959>

    tailing space



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134964>

    Do you need to cover null value case?



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134960>

    tailing spaces



serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java
<https://reviews.apache.org/r/34235/#comment134962>

    remove space pls


Some minor issues and a question

- cheng xu


On May 14, 2015, 10:07 p.m., Swarnim Kulkarni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34235/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 10:07 p.m.)
> 
> 
> Review request for hive and Brock Noland.
> 
> 
> Bugs: HIVE-10687
>     https://issues.apache.org/jira/browse/HIVE-10687
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-10687 Fix avro deserialization issues for evolved unions
> 
> 
> Diffs
> -----
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java e94cd83c064199ba719cc2de222edd0e12401c8c

>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroDeserializer.java eb495b4e1fc5874b30936f646b5bdb5aa8734130

>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroObjectInspectorGenerator.java
c9e7d68b211ebc8c66af243fe85f4f89c6fd6cf3 
> 
> Diff: https://reviews.apache.org/r/34235/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swarnim Kulkarni
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message