hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov" <apivova...@gmail.com>
Subject Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality
Date Thu, 14 May 2015 06:39:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33881/#review83724
-----------------------------------------------------------



beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java
<https://reviews.apache.org/r/33881/#comment134770>

    You can use IOUtils.closeQuietly(bw)
    I do not think we need to log close buffer error


- Alexander Pivovarov


On May 14, 2015, 5:51 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33881/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 5:51 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-10623
>     https://issues.apache.org/jira/browse/HIVE-10623
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changes:
> 1. Support the hive cli options including database, e, !, H, f.
> 2. Add error handler for using f and e together
> 3. Add error handler for invalid option
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java 0da15f6 
>   beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java PRE-CREATION

>   beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION 
>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION 
>   beeline/src/test/resources/hive-site.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33881/diff/
> 
> 
> Testing
> -------
> 
> Newly add unit test passed locally.
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message