hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 33881: HIVE-10623 Implement hive cli options using beeline functionality
Date Sat, 09 May 2015 12:28:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33881/#review83143
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/33881/#comment134021>

    We might just call the next method in this method to avoid code duplication.



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/33881/#comment134022>

    code style



beeline/src/java/org/apache/hive/beeline/BeeLine.java
<https://reviews.apache.org/r/33881/#comment134024>

    I believe that currently Hive CLI is able to connect a metastore other than the embedded
derby. Thus, we need to make sure that the embedded HS2 is also able to do that. It's unclear
to me how is that achieved, maybe via hive-site.xml. Please verify this case is covered.


- Xuefu Zhang


On May 6, 2015, 6:32 a.m., cheng xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33881/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 6:32 a.m.)
> 
> 
> Review request for hive and Xuefu Zhang.
> 
> 
> Bugs: HIVE-10623
>     https://issues.apache.org/jira/browse/HIVE-10623
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Changes:
> 1. Support the hive cli options including database, e, !, H, f.
> 2. Add error handler for using f and e together
> 3. Add error handler for invalid option
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java b3d89cb 
>   beeline/src/java/org/apache/hive/beeline/cli/CliOptionsProcessor.java PRE-CREATION

>   beeline/src/java/org/apache/hive/beeline/cli/HiveCli.java PRE-CREATION 
>   beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33881/diff/
> 
> 
> Testing
> -------
> 
> Newly add unit test passed locally.
> 
> 
> Thanks,
> 
> cheng xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message