hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Reuben Kuhnert" <sircodesa...@gmail.com>
Subject Re: Review Request 33816: HIVE-10597: Relative path doesn't work with CREATE TABLE LOCATION 'relative/path'
Date Thu, 07 May 2015 12:29:39 GMT


> On May 7, 2015, 1:03 a.m., cheng xu wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java, line 143
> > <https://reviews.apache.org/r/33816/diff/2/?file=950357#file950357line143>
> >
> >     Will this patch work with relative path? Seems only a check added.

Originally I used the warehouse home directory as the base for relative paths. However, per
Lenni's comment, it sounds like it's best to throw an exception if the user tries to use a
anything other than an absolute path.


- Reuben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33816/#review82781
-----------------------------------------------------------


On May 5, 2015, 3:14 p.m., Reuben Kuhnert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33816/
> -----------------------------------------------------------
> 
> (Updated May 5, 2015, 3:14 p.m.)
> 
> 
> Review request for hive and Sergio Pena.
> 
> 
> Bugs: HIVE-10597
>     https://issues.apache.org/jira/browse/HIVE-10597
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Allow warehouse to work with relative locations.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 25119abf97382df7c0615edbaff29ba20624a137

>   metastore/src/test/org/apache/hadoop/hive/metastore/TestWarehouse.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/33816/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Reuben Kuhnert
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message