Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E501417EB1 for ; Wed, 22 Apr 2015 06:05:28 +0000 (UTC) Received: (qmail 83644 invoked by uid 500); 22 Apr 2015 06:05:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 83574 invoked by uid 500); 22 Apr 2015 06:05:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 83490 invoked by uid 99); 22 Apr 2015 06:05:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 06:05:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A60CB1CE0CC; Wed, 22 Apr 2015 06:05:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1915283044225222270==" MIME-Version: 1.0 Subject: Re: Review Request 33367: Aggregate stats cache for RDBMS based metastore codepath From: "Thejas Nair" To: "Vaibhav Gumashta" , "Thejas Nair" , "hive" Date: Wed, 22 Apr 2015 06:05:29 -0000 Message-ID: <20150422060529.2948.8456@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/33367/ X-Sender: "Thejas Nair" References: <20150420184437.2948.4820@reviews.apache.org> In-Reply-To: <20150420184437.2948.4820@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============1915283044225222270== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33367/#review81122 ----------------------------------------------------------- metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java i would expect this map entry to be non null for vast majority of this call done from here. Creating a new (arraylist) object is usually considered expensive, so i feel it would better to error on the side of having to make an additional put call. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java looking up in the db separately for each column will be expensive. We should make a single call for columns not in cache and then create the aggregated results. Again a perf improvement that we can track in a followup jira. - Thejas Nair On April 20, 2015, 6:44 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33367/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 6:44 p.m.) > > > Review request for hive. > > > Bugs: HIVE-10382 > https://issues.apache.org/jira/browse/HIVE-10382 > > > Repository: hive-git > > > Description > ------- > > Similar to the work done on the HBase branch (HIVE-9693), the stats cache can potentially have performance gains. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 65ec1b9 > common/src/java/org/apache/hive/common/util/BloomFilter.java PRE-CREATION > common/src/java/org/apache/hive/common/util/Murmur3.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestBloomFilter.java PRE-CREATION > common/src/test/org/apache/hive/common/util/TestMurmur3.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/AggregateStatsCache.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java bf169c9 > metastore/src/test/org/apache/hadoop/hive/metastore/TestAggregateStatsCache.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/filters/BloomFilter.java 6ab0270 > ql/src/java/org/apache/hadoop/hive/ql/io/filters/BloomFilterIO.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/filters/Murmur3.java e733892 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/FileDump.java 7bfd781 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 49a8e80 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java bde9fc2 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java a319204 > ql/src/test/org/apache/hadoop/hive/ql/io/filters/TestBloomFilter.java 32b95ab > ql/src/test/org/apache/hadoop/hive/ql/io/filters/TestMurmur3.java d92a3ce > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java d0f3a5e > > Diff: https://reviews.apache.org/r/33367/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > > --===============1915283044225222270==--