Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B42961757A for ; Wed, 22 Apr 2015 01:25:25 +0000 (UTC) Received: (qmail 24826 invoked by uid 500); 22 Apr 2015 01:25:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 24752 invoked by uid 500); 22 Apr 2015 01:25:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 24739 invoked by uid 99); 22 Apr 2015 01:25:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Apr 2015 01:25:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1EA011CE0CC; Wed, 22 Apr 2015 01:25:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8419202695217218506==" MIME-Version: 1.0 Subject: Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch] From: "Chao Sun" To: "Marcelo Vanzin" Cc: "hive" , "Chao Sun" Date: Wed, 22 Apr 2015 01:25:26 -0000 Message-ID: <20150422012526.2947.21343@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Chao Sun" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/33422/ X-Sender: "Chao Sun" References: <20150422003028.2947.97197@reviews.apache.org> In-Reply-To: <20150422003028.2947.97197@reviews.apache.org> Reply-To: "Chao Sun" X-ReviewRequest-Repository: hive-git --===============8419202695217218506== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33422/ ----------------------------------------------------------- (Updated April 22, 2015, 1:25 a.m.) Review request for hive and Marcelo Vanzin. Bugs: HIVE-10434 https://issues.apache.org/jira/browse/HIVE-10434 Repository: hive-git Description ------- This patch cancels the connection from HS2 to remote process once the latter has failed and exited with error code, to avoid potential long timeout. It add a new public method cancelClient to the RpcServer class - not sure whether there's an easier way to do this.. Diffs (updated) ----- spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 71e432d spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java 32d4c46 Diff: https://reviews.apache.org/r/33422/diff/ Testing ------- Tested on my own cluster, and it worked. Thanks, Chao Sun --===============8419202695217218506==--