Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8488417ECF for ; Wed, 15 Apr 2015 20:38:55 +0000 (UTC) Received: (qmail 77881 invoked by uid 500); 15 Apr 2015 20:38:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 77811 invoked by uid 500); 15 Apr 2015 20:38:55 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 77796 invoked by uid 99); 15 Apr 2015 20:38:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2015 20:38:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0BFFA1D9C7F; Wed, 15 Apr 2015 20:38:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7929693001775889240==" MIME-Version: 1.0 Subject: Re: Review Request 33186: HIVE-10270 Cannot use Decimal constants less than 0.1BD From: "Jason Dere" To: "Xuefu Zhang" , "Gunther Hagleitner" Cc: "Jason Dere" , "hive" Date: Wed, 15 Apr 2015 20:38:57 -0000 Message-ID: <20150415203857.1421.85134@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/33186/ X-Sender: "Jason Dere" References: <20150414195657.14114.34614@reviews.apache.org> In-Reply-To: <20150414195657.14114.34614@reviews.apache.org> Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============7929693001775889240== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33186/ ----------------------------------------------------------- (Updated April 15, 2015, 8:38 p.m.) Review request for hive, Gunther Hagleitner and Xuefu Zhang. Changes ------- For Patch v5 I have refactored it so both BinarySortableSerDe and BinarySortableSerializeWrite both call into the same common logic, and updated the tests for TestBinarySortableFast, similar to TestBinarySortableSerDe. Bugs: HIVE-10270 https://issues.apache.org/jira/browse/HIVE-10270 Repository: hive-git Description ------- Change HiveDecimal.precision() to return the SQL precision rather than BigDecimal.precision() Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java c2bf6d7 ql/src/test/queries/clientpositive/decimal_precision2.q PRE-CREATION ql/src/test/results/clientpositive/decimal_precision2.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java a6ab7a7 serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/fast/BinarySortableSerializeWrite.java f62def8 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestClass.java 370e857 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/MyTestPrimitiveClass.java 2e2327b serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableFast.java 83d3839 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java b3fb3be Diff: https://reviews.apache.org/r/33186/diff/ Testing ------- Thanks, Jason Dere --===============7929693001775889240==--