Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D0B7917DD5 for ; Wed, 8 Apr 2015 14:01:42 +0000 (UTC) Received: (qmail 87740 invoked by uid 500); 8 Apr 2015 14:00:44 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 87667 invoked by uid 500); 8 Apr 2015 14:00:44 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 87654 invoked by uid 99); 8 Apr 2015 14:00:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Apr 2015 14:00:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9164B1C0115; Wed, 8 Apr 2015 14:00:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3122221853005117922==" MIME-Version: 1.0 Subject: Re: Review Request 32966: HIVE-10251: HIVE-9664 makes hive depend on ivysettings.xml From: "Swarnim Kulkarni" To: "Swarnim Kulkarni" , "Anant Nag" , "hive" Date: Wed, 08 Apr 2015 14:00:41 -0000 Message-ID: <20150408140041.18051.32414@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Swarnim Kulkarni" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32966/ X-Sender: "Swarnim Kulkarni" References: <20150408071314.18051.29876@reviews.apache.org> In-Reply-To: <20150408071314.18051.29876@reviews.apache.org> Reply-To: "Swarnim Kulkarni" X-ReviewRequest-Repository: hive-git --===============3122221853005117922== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32966/#review79344 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java You would reach here only if both ivysettings.xml and defaultGrapeConfig.xml are missing. Should the message indicate that as well? ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java Seems like this should be something more severe than just an INFO. A WARN maybe? - Swarnim Kulkarni On April 8, 2015, 7:13 a.m., Anant Nag wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32966/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 7:13 a.m.) > > > Review request for hive. > > > Bugs: HIVE-10251 > https://issues.apache.org/jira/browse/HIVE-10251 > > > Repository: hive-git > > > Description > ------- > > * DependencyResolver is now not initialized in constructor. > * Changed all methods of DependencyResolver to static and added static initialization block > * Added additional checks for ivysettings.xml file. If it is not found in classpath then defaultGrapeConfig.xml is used instead. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java 27bf3e46291e02bd689d7f3ac2cb5e71a18c8b2b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 66cff87d118ee22f2e8308b0b5c70f87d99d5625 > > Diff: https://reviews.apache.org/r/32966/diff/ > > > Testing > ------- > > > Thanks, > > Anant Nag > > --===============3122221853005117922==--