Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0CA21178D7 for ; Tue, 7 Apr 2015 22:05:11 +0000 (UTC) Received: (qmail 62253 invoked by uid 500); 7 Apr 2015 22:05:10 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 62183 invoked by uid 500); 7 Apr 2015 22:05:10 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 62163 invoked by uid 99); 7 Apr 2015 22:05:10 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Apr 2015 22:05:10 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 49EC61D929E; Tue, 7 Apr 2015 22:05:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0858490435153487480==" MIME-Version: 1.0 Subject: Re: Review Request 32901: HIVE-10226 Column stats for Date columns not supported From: "Jason Dere" To: "Ashutosh Chauhan" , j.prasanth.j@gmail.com Cc: "Swarnim Kulkarni" , "Jason Dere" , "hive" Date: Tue, 07 Apr 2015 22:05:08 -0000 Message-ID: <20150407220508.5638.38473@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32901/ X-Sender: "Jason Dere" References: <20150407214806.5637.78623@reviews.apache.org> In-Reply-To: <20150407214806.5637.78623@reviews.apache.org> Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============0858490435153487480== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32901/ ----------------------------------------------------------- (Updated April 7, 2015, 10:05 p.m.) Review request for hive, Ashutosh Chauhan and Prasanth_J. Changes ------- Check for null values in Date/Decimal versions of MetaDataFormatUtils.convertToString() Bugs: HIVE-10226 https://issues.apache.org/jira/browse/HIVE-10226 Repository: hive-git Description ------- Re-use the long stats for Date column stats, using the days since epoch value as the long value. Diffs (updated) ----- metastore/if/hive_metastore.thrift 57bce0c metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java 1666dc3 metastore/src/model/org/apache/hadoop/hive/metastore/model/MTableColumnStatistics.java bce9f0f ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 0c46b00 ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsUpdateTask.java b85282c ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java 1662696 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 363039b ql/src/test/queries/clientpositive/compute_stats_date.q PRE-CREATION ql/src/test/results/clientpositive/compute_stats_date.q.out PRE-CREATION Diff: https://reviews.apache.org/r/32901/diff/ Testing ------- Thanks, Jason Dere --===============0858490435153487480==--