Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 01F781751E for ; Wed, 1 Apr 2015 20:26:34 +0000 (UTC) Received: (qmail 58717 invoked by uid 500); 1 Apr 2015 20:26:33 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 58649 invoked by uid 500); 1 Apr 2015 20:26:33 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 58632 invoked by uid 99); 1 Apr 2015 20:26:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Apr 2015 20:26:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E11421D703F; Wed, 1 Apr 2015 20:26:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5410203897102074495==" MIME-Version: 1.0 Subject: Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions From: "Jason Dere" To: "Ashutosh Chauhan" , "Thejas Nair" Cc: "Jason Dere" , "hive" Date: Wed, 01 Apr 2015 20:26:31 -0000 Message-ID: <20150401202631.16791.68139@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32324/ X-Sender: "Jason Dere" References: <20150401013454.16792.18747@reviews.apache.org> In-Reply-To: <20150401013454.16792.18747@reviews.apache.org> Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============5410203897102074495== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On April 1, 2015, 1:34 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java, line 167 > > > > > > can we re-use typeStringToHiveType here ? > > I see void and null as only things that need to be handled separately. that makes sense, I can make that change - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32324/#review78462 ----------------------------------------------------------- On March 20, 2015, 11:48 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32324/ > ----------------------------------------------------------- > > (Updated March 20, 2015, 11:48 p.m.) > > > Review request for hive, Ashutosh Chauhan and Thejas Nair. > > > Bugs: HIVE-10037 > https://issues.apache.org/jira/browse/HIVE-10037 > > > Repository: hive-git > > > Description > ------- > > There is no interval type in Jdbc, so year-month intervals and day-time intervals both use java.sql.Types.OTHER as the Jdbc type. > Also does some changes in JdbcColumn/HiveResultSetMetaData to allow a more accurate column precision/display size in the case of interval types, and to allow users to use get the HiveIntervalYearMonth/HiveIntervalDayTime values when calling ResultSet.getObject(). > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 2c85877 > jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java cd1916f > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 764a3f1 > jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 3fcdd56 > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 4383f56 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 2758eb0 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b9e15a1 > service/if/TCLIService.thrift 6f1a4ca > service/src/java/org/apache/hive/service/cli/ColumnValue.java 9b48396 > service/src/java/org/apache/hive/service/cli/Type.java 92d237d > > Diff: https://reviews.apache.org/r/32324/diff/ > > > Testing > ------- > > Added test to TestJdbcDriver2 > > > Thanks, > > Jason Dere > > --===============5410203897102074495==--