hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Gumashta" <vgumas...@hortonworks.com>
Subject Re: Review Request 28109: HiveServer2 dynamic service discovery: use persistent ephemeral nodes curator recipe
Date Tue, 28 Apr 2015 18:41:00 GMT


> On Jan. 30, 2015, 8:26 p.m., Thejas Nair wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1337
> > <https://reviews.apache.org/r/28109/diff/3/?file=836237#file836237line1337>
> >
> >     how about using seconds instead of milliseconds, most people would not care
about the millisecond part.

HIVE_ZOOKEEPER_CONNECTION_BASESLEEPTIME uses ms and it is reasonable to expect it to be configured
< 1s. I'm thinking it's better to keep consistent units. What do you think?


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28109/#review70303
-----------------------------------------------------------


On April 28, 2015, 6:40 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28109/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 6:40 p.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-8890
>     https://issues.apache.org/jira/browse/HIVE-8890
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8890
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java c9ee423 
>   pom.xml 9a1dae9 
>   service/pom.xml 421bb9b 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ca1eae6

>   service/src/java/org/apache/hive/service/server/HiveServer2.java 222cb45 
> 
> Diff: https://reviews.apache.org/r/28109/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message