hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chao Sun" <chao....@cloudera.com>
Subject Re: Review Request 33422: HIVE-10434 - Cancel connection when remote Spark driver process has failed [Spark Branch]
Date Thu, 23 Apr 2015 18:11:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33422/
-----------------------------------------------------------

(Updated April 23, 2015, 6:11 p.m.)


Review request for hive and Marcelo Vanzin.


Changes
-------

Addressing Marcelo's comment.


Bugs: HIVE-10434
    https://issues.apache.org/jira/browse/HIVE-10434


Repository: hive-git


Description
-------

This patch cancels the connection from HS2 to remote process once the latter has failed and
exited with error code, to
avoid potential long timeout.
It add a new public method cancelClient to the RpcServer class - not sure whether there's
an easier way to do this..


Diffs (updated)
-----

  spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java 71e432d 
  spark-client/src/main/java/org/apache/hive/spark/client/rpc/RpcServer.java 32d4c46 

Diff: https://reviews.apache.org/r/33422/diff/


Testing
-------

Tested on my own cluster, and it worked.


Thanks,

Chao Sun


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message