hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anant Nag" <nntna...@gmail.com>
Subject Re: Review Request 32966: HIVE-10251: HIVE-9664 makes hive depend on ivysettings.xml
Date Fri, 10 Apr 2015 13:34:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32966/
-----------------------------------------------------------

(Updated April 10, 2015, 1:34 p.m.)


Review request for hive.


Changes
-------

* Added unit test.
* Moved ivysettings.xml check to a separate function
* Added hive-ivysettings-default.xml file which will be packed in hive-exec jar.


Bugs: HIVE-10251
    https://issues.apache.org/jira/browse/HIVE-10251


Repository: hive-git


Description
-------

* DependencyResolver is now not initialized in constructor. 
* Changed all methods of DependencyResolver to static and added static initialization block

* Added additional checks for ivysettings.xml file. If it is not found in classpath then defaultGrapeConfig.xml
is used instead.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java b20e975416a8565d5668c509ef62a3ca1c46989a

  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 66cff87d118ee22f2e8308b0b5c70f87d99d5625

  ql/src/main/resources/org/apache/hadoop/hive/ql/session/hive-ivysettings-default.xml PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/session/TestDependencyResolver.java PRE-CREATION 

Diff: https://reviews.apache.org/r/32966/diff/


Testing
-------


Thanks,

Anant  Nag


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message