hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni" <kulkarni.swar...@gmail.com>
Subject Re: Review Request 32732: HIVE-3378 UDF to obtain the numeric day of an year from date or timestamp in HIVE
Date Thu, 09 Apr 2015 20:34:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32732/#review79569
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayOfYear.java
<https://reviews.apache.org/r/32732/#comment129023>

    I have usually seen GenericUDFS been used in cases where we need to use complex types.
Little confused on why can't we get by here with a regular UDF and have an implementation
similar to the dayofmonth UDF?
    
    Or is there something that I am missing?
    
    [1] https://github.com/cloudera/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayOfYear.java
<https://reviews.apache.org/r/32732/#comment129026>

    Move inside the evaluate method.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayOfYear.java
<https://reviews.apache.org/r/32732/#comment129025>

    Does this need to be a global variable? Can't you move this inside the evaluate method
itself?



ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayOfYear.java
<https://reviews.apache.org/r/32732/#comment129027>

    Why is this test commented out?


- Swarnim Kulkarni


On April 1, 2015, 5:56 p.m., Alexander Pivovarov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32732/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 5:56 p.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Bugs: HIVE-3378
>     https://issues.apache.org/jira/browse/HIVE-3378
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-3378 UDF to obtain the numeric day of an year from date or timestamp in HIVE
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 2476e832b8b7101971ea2226368aa82633b7e7d1

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDayOfYear.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDayOfYear.java PRE-CREATION

>   ql/src/test/queries/clientpositive/udf_dayofyear.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out 22091d06241218a5c0ee21d6ee6be00a71706971

>   ql/src/test/results/clientpositive/udf_dayofyear.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32732/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message