hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner" <ghagleit...@hortonworks.com>
Subject Re: Review Request 32966: HIVE-10251: HIVE-9664 makes hive depend on ivysettings.xml
Date Wed, 08 Apr 2015 19:34:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32966/#review79412
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java
<https://reviews.apache.org/r/32966/#comment128742>

    is it possible to not print this on the console (logs only)? or at least only print when
you find a specific file (the reverse of what you're doing now). there's no reason to alert
someone that the file wasn't found if they're not interested in this feature.



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
<https://reviews.apache.org/r/32966/#comment128741>

    why are you turning all this into static methods? using actual objects is more testable/maintainable
no?


- Gunther Hagleitner


On April 8, 2015, 7:13 a.m., Anant  Nag wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32966/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 7:13 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-10251
>     https://issues.apache.org/jira/browse/HIVE-10251
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> * DependencyResolver is now not initialized in constructor. 
> * Changed all methods of DependencyResolver to static and added static initialization
block 
> * Added additional checks for ivysettings.xml file. If it is not found in classpath then
defaultGrapeConfig.xml is used instead.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/session/DependencyResolver.java 27bf3e46291e02bd689d7f3ac2cb5e71a18c8b2b

>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 66cff87d118ee22f2e8308b0b5c70f87d99d5625

> 
> Diff: https://reviews.apache.org/r/32966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anant  Nag
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message