hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Pullokkaran" <jpullokka...@hortonworks.com>
Subject Re: Review Request 32370: HIVE-10040
Date Tue, 07 Apr 2015 18:35:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32370/#review79228
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java
<https://reviews.apache.org/r/32370/#comment128449>

    As we discussed:
    1. Move the supported JoinAlgorithm to Sub Class (i.e target exec engine)
    2. Move Cost Computation to sub class/target exec engine
    3. This logic here should consult target exec engine for supported algorithms, iterate
through them and find the cheapest one with out actually knowing anything about algorithm
itself.


- John Pullokkaran


On April 6, 2015, 9:30 p.m., Jesús Camacho Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32370/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 9:30 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Bugs: HIVE-10040
>     https://issues.apache.org/jira/browse/HIVE-10040
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> CBO (Calcite Return Path): Pluggable cost modules [CBO branch]
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7adb38342bfaf72f152a16006bc0bfecbb28f5ed

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java
977313a5a632329fc963daf7ff276ccdd59ce7c5 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCost.java 41604cd0af68e7f90296fa271c42debc5aaf743a

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java
PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java PRE-CREATION

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java
9a8a5da81b92c7c1f33d1af8072b1fb94e237290 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java
3e45a3fbed3265b126a3ff9b6ffe44bee24453ef 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java
f411d9029cf244b66ef1d1591ea55f11f7cb9d27 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveLimit.java
5fc64f3e8c97fc8988bc35be39dbabf78dd7de24 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java
6c215c96190f0fcebe063b15c2763c49ebf1faaf 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java
fcf09a5de0e318c6fb69664a8dd618f2d9ae84e5 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdCollation.java
4984683c3c8c6c0378a22e21fd6d961f3901f25c 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java
f846dd19899af51194f3407ef913fcb9bcc24977 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java
dabbe280278dc80f00f0240a0c615fe6c7b8533a 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java
95515b23e409d73d5c61e107931727add3f992a6 
> 
> Diff: https://reviews.apache.org/r/32370/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message