hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "chengxiang li" <chengxiang...@intel.com>
Subject Review Request 32918: HIVE-10180 Loop optimization for SIMD in ColumnArithmeticColumn.txt
Date Tue, 07 Apr 2015 05:46:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32918/
-----------------------------------------------------------

Review request for hive.


Bugs: Hive-10180
    https://issues.apache.org/jira/browse/Hive-10180


Repository: hive


Description
-------

JVM is quite strict on the code schema which may executed with SIMD instructions, take a loop
in DoubleColAddDoubleColumn.java for example,
for (int i = 0; i != n; i++) {
  outputVector[i] = vector1[0] + vector2[i];
}
The "vector1[0]" reference would prevent JVM to execute this part of code with vectorized
instructions, we need to assign the "vector1[0]" to a variable outside of loop, and use that
variable in loop.


Diffs
-----

  trunk/ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt 1671736 

Diff: https://reviews.apache.org/r/32918/diff/


Testing
-------


Thanks,

chengxiang li


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message