hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Swarnim Kulkarni" <kulkarni.swar...@gmail.com>
Subject Re: Review Request 32901: HIVE-10226 Column stats for Date columns not supported
Date Tue, 07 Apr 2015 04:19:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32901/#review79119
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/32901/#comment128230>

    Nit: Add javadoc here.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/32901/#comment128231>

    Would it be a little safer here to assert that "parameters" has atleast 2 values in it
so that we do not fail with an ArrayIndexOutOfBoundsException?



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
<https://reviews.apache.org/r/32901/#comment128229>

    Nit: Else not needed.



ql/src/test/results/clientpositive/compute_stats_date.q.out
<https://reviews.apache.org/r/32901/#comment128232>

    Getting rid of the tabs here would be nice.


- Swarnim Kulkarni


On April 6, 2015, 9:01 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32901/
> -----------------------------------------------------------
> 
> (Updated April 6, 2015, 9:01 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Prasanth_J.
> 
> 
> Bugs: HIVE-10226
>     https://issues.apache.org/jira/browse/HIVE-10226
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Re-use the long stats for Date column stats, using the days since epoch value as the
long value.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java 475883b

>   ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 0c46b00 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java 363039b

>   ql/src/test/queries/clientpositive/compute_stats_date.q PRE-CREATION 
>   ql/src/test/results/clientpositive/compute_stats_date.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/32901/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message