hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 32324: HIVE-10037 JDBC support for interval expressions
Date Wed, 01 Apr 2015 20:26:31 GMT


> On April 1, 2015, 1:34 a.m., Thejas Nair wrote:
> > jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java, line 167
> > <https://reviews.apache.org/r/32324/diff/2/?file=901924#file901924line167>
> >
> >     can we re-use typeStringToHiveType here ?
> >     I see void and null as only things that need to be handled separately.

that makes sense, I can make that change


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32324/#review78462
-----------------------------------------------------------


On March 20, 2015, 11:48 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32324/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 11:48 p.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Thejas Nair.
> 
> 
> Bugs: HIVE-10037
>     https://issues.apache.org/jira/browse/HIVE-10037
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> There is no interval type in Jdbc, so year-month intervals and day-time intervals both
use java.sql.Types.OTHER as the Jdbc type.
> Also does some changes in JdbcColumn/HiveResultSetMetaData to allow a more accurate column
precision/display size in the case of interval types, and to allow users to use get the HiveIntervalYearMonth/HiveIntervalDayTime
values when calling ResultSet.getObject().
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 2c85877 
>   jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java cd1916f 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 764a3f1 
>   jdbc/src/java/org/apache/hive/jdbc/HiveResultSetMetaData.java 3fcdd56 
>   jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 4383f56 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 2758eb0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b9e15a1 
>   service/if/TCLIService.thrift 6f1a4ca 
>   service/src/java/org/apache/hive/service/cli/ColumnValue.java 9b48396 
>   service/src/java/org/apache/hive/service/cli/Type.java 92d237d 
> 
> Diff: https://reviews.apache.org/r/32324/diff/
> 
> 
> Testing
> -------
> 
> Added test to TestJdbcDriver2
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message