Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4A614173C6 for ; Tue, 31 Mar 2015 21:33:08 +0000 (UTC) Received: (qmail 35043 invoked by uid 500); 31 Mar 2015 21:32:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 34970 invoked by uid 500); 31 Mar 2015 21:32:55 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 34956 invoked by uid 99); 31 Mar 2015 21:32:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Mar 2015 21:32:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B7BB91D7029; Tue, 31 Mar 2015 21:32:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1868298478600863752==" MIME-Version: 1.0 Subject: Re: Review Request 32489: HIVE-9518 Implement MONTHS_BETWEEN aligned with Oracle one From: "Alexander Pivovarov" To: "Jason Dere" Cc: "Alexander Pivovarov" , "Mohit Sabharwal" , "hive" Date: Tue, 31 Mar 2015 21:32:53 -0000 Message-ID: <20150331213253.16792.69398@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Pivovarov" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32489/ X-Sender: "Alexander Pivovarov" References: <20150331200838.16792.21722@reviews.apache.org> In-Reply-To: <20150331200838.16792.21722@reviews.apache.org> Reply-To: "Alexander Pivovarov" X-ReviewRequest-Repository: hive-git --===============1868298478600863752== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32489/ ----------------------------------------------------------- (Updated March 31, 2015, 9:32 p.m.) Review request for hive and Jason Dere. Changes ------- patch #10 - added SEC_IN_31_DAYS constant for clarity Bugs: HIVE-9518 https://issues.apache.org/jira/browse/HIVE-9518 Repository: hive-git Description ------- HIVE-9518 Implement MONTHS_BETWEEN aligned with Oracle one Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 2476e832b8b7101971ea2226368aa82633b7e7d1 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java ce981232382e993c7c9d640efe9b2d21f70a0ed4 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFMonthsBetween.java PRE-CREATION ql/src/test/queries/clientpositive/udf_months_between.q PRE-CREATION ql/src/test/results/clientpositive/show_functions.q.out 22091d06241218a5c0ee21d6ee6be00a71706971 ql/src/test/results/clientpositive/udf_months_between.q.out PRE-CREATION Diff: https://reviews.apache.org/r/32489/diff/ Testing ------- Thanks, Alexander Pivovarov --===============1868298478600863752==--