Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F2D1017648 for ; Mon, 30 Mar 2015 23:48:49 +0000 (UTC) Received: (qmail 66466 invoked by uid 500); 30 Mar 2015 23:48:49 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 66394 invoked by uid 500); 30 Mar 2015 23:48:49 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 66373 invoked by uid 99); 30 Mar 2015 23:48:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Mar 2015 23:48:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E8431D5C7A; Mon, 30 Mar 2015 23:48:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7848514880334376855==" MIME-Version: 1.0 Subject: Re: Review Request 32370: HIVE-10040 From: "John Pullokkaran" To: "John Pullokkaran" Cc: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= , hive Date: Mon, 30 Mar 2015 23:48:48 -0000 Message-ID: <20150330234848.16792.37649@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "John Pullokkaran" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32370/ X-Sender: "John Pullokkaran" References: <20150327161553.15432.92207@reviews.apache.org> In-Reply-To: <20150327161553.15432.92207@reviews.apache.org> Reply-To: "John Pullokkaran" X-ReviewRequest-Repository: hive-git --===============7848514880334376855== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32370/#review78284 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java Can't we walk through the algorithms and compare cost here as opposed to in the sub classes. Fall back to using cardinality if only possible algorithm is "NONE" - John Pullokkaran On March 27, 2015, 4:15 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32370/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 4:15 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-10040 > https://issues.apache.org/jira/browse/HIVE-10040 > > > Repository: hive-git > > > Description > ------- > > CBO (Calcite Return Path): Pluggable cost modules [CBO branch] > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveDefaultRelMetadataProvider.java 977313a5a632329fc963daf7ff276ccdd59ce7c5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCost.java 41604cd0af68e7f90296fa271c42debc5aaf743a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveCostModel.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveDefaultCostModel.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveOnTezCostModel.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/cost/HiveRelMdCost.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java 9a8a5da81b92c7c1f33d1af8072b1fb94e237290 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java 3e45a3fbed3265b126a3ff9b6ffe44bee24453ef > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java e2b010b641d48ea1bf04750ddf5eb24fb3a7fcbe > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveLimit.java 5fc64f3e8c97fc8988bc35be39dbabf78dd7de24 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java 6c215c96190f0fcebe063b15c2763c49ebf1faaf > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java f2c5408d913bfe2648c4e1e1e43b1bbc5f43a549 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdCollation.java 4984683c3c8c6c0378a22e21fd6d961f3901f25c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdDistribution.java f846dd19899af51194f3407ef913fcb9bcc24977 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdRowCount.java dabbe280278dc80f00f0240a0c615fe6c7b8533a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdUniqueKeys.java 95515b23e409d73d5c61e107931727add3f992a6 > > Diff: https://reviews.apache.org/r/32370/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > > --===============7848514880334376855==--