Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 06CBE17FCE for ; Thu, 26 Mar 2015 22:03:40 +0000 (UTC) Received: (qmail 23000 invoked by uid 500); 26 Mar 2015 22:03:28 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 22922 invoked by uid 500); 26 Mar 2015 22:03:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 22899 invoked by uid 99); 26 Mar 2015 22:03:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Mar 2015 22:03:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 793E71D54C2; Thu, 26 Mar 2015 22:03:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5489884968604590943==" MIME-Version: 1.0 Subject: Re: Review Request 32551: HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 From: "Szehon Ho" To: "Szehon Ho" Cc: "Aihua Xu" , "hive" Date: Thu, 26 Mar 2015 22:03:27 -0000 Message-ID: <20150326220327.15432.11339@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Szehon Ho" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/32551/ X-Sender: "Szehon Ho" References: <20150326215542.1505.50247@reviews.apache.org> In-Reply-To: <20150326215542.1505.50247@reviews.apache.org> Reply-To: "Szehon Ho" X-ReviewRequest-Repository: hive-git --===============5489884968604590943== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32551/#review77956 ----------------------------------------------------------- It looks good Aihua except minor points below, I suppose its unfortunate that the TokenStore init method all take in objectStore even if only one needs it. service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java I think we should use .equals comparison. Also need to get rid of the preceding space in the if condition. Also please remove the extra whitespace. - Szehon Ho On March 26, 2015, 9:55 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32551/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 9:55 p.m.) > > > Review request for hive and Szehon Ho. > > > Repository: hive-git > > > Description > ------- > > HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > > > Diffs > ----- > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHiveAuthFactory.java a30ec7e9e5e079f7c13456c29082121da9b6c202 > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 22c309fbfd941fb517370057ef38fbec903ce088 > > Diff: https://reviews.apache.org/r/32551/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > > --===============5489884968604590943==--