Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C654317A29 for ; Thu, 5 Mar 2015 03:44:58 +0000 (UTC) Received: (qmail 62026 invoked by uid 500); 5 Mar 2015 03:44:55 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 61922 invoked by uid 500); 5 Mar 2015 03:44:55 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 61892 invoked by uid 99); 5 Mar 2015 03:44:55 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Mar 2015 03:44:55 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F031B1D22DF; Thu, 5 Mar 2015 03:44:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5271875834028108422==" MIME-Version: 1.0 Subject: Re: Review Request 31759: HIVE-9620: Cannot retrieve column statistics using HMS API if column name contains uppercase characters From: "Xuefu Zhang" To: "Szehon Ho" , "Xuefu Zhang" , "Ashutosh Chauhan" , "Brock Noland" Cc: "hive" , "Chaoyu Tang" , "Xuefu Zhang" Date: Thu, 05 Mar 2015 03:44:53 -0000 Message-ID: <20150305034453.12262.36112@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/31759/ X-Sender: "Xuefu Zhang" References: <20150305031657.5896.28672@reviews.apache.org> In-Reply-To: <20150305031657.5896.28672@reviews.apache.org> Reply-To: "Xuefu Zhang" X-ReviewRequest-Repository: hive-git --===============5271875834028108422== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31759/#review75287 ----------------------------------------------------------- Ship it! Ship It! - Xuefu Zhang On March 5, 2015, 3:16 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31759/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 3:16 a.m.) > > > Review request for hive, Ashutosh Chauhan, Brock Noland, Szehon Ho, and Xuefu Zhang. > > > Bugs: HIVE-9620 > https://issues.apache.org/jira/browse/HIVE-9620 > > > Repository: hive-git > > > Description > ------- > > The identifier such as column name is stored in lowercase in metastore backend tables. Hive usually converts these identifiers to lowercase before calling HMS APIs, but it might not be always true. Other HMS clients like Impala might also not do that. So we need convert the identifiers in HMS request to lowercase in HiveMetaStore.java before querying backend tables. Some existing APIs in HiveMetaStore have already done this conversion but others have not, especially those APIs for Statistics with StatsRequest. This patch is going to change all these identifiers passed in StatRequest to lowercase before querying backend tables. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 379abaf3cd883163e6b94c86f35c501024c98150 > > Diff: https://reviews.apache.org/r/31759/diff/ > > > Testing > ------- > > PreCommit tests passed: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2946/testReport > > > Thanks, > > Chaoyu Tang > > --===============5271875834028108422==--