hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aihua Xu" <...@cloudera.com>
Subject Re: Review Request 32551: HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
Date Fri, 27 Mar 2015 01:44:28 GMT


> On March 26, 2015, 10:03 p.m., Szehon Ho wrote:
> > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java, line 118
> > <https://reviews.apache.org/r/32551/diff/1/?file=907101#file907101line118>
> >
> >     I think we should use .equals comparison.  Also need to get rid of the preceding
space in the if condition.

For some reason, I couldn't upload a new diff (give an error). I removed the extra spaces
and replaced == with equals().


- Aihua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32551/#review77956
-----------------------------------------------------------


On March 26, 2015, 9:55 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32551/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 9:55 p.m.)
> 
> 
> Review request for hive and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
> 
> 
> Diffs
> -----
> 
>   itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHiveAuthFactory.java
a30ec7e9e5e079f7c13456c29082121da9b6c202 
>   service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 22c309fbfd941fb517370057ef38fbec903ce088

> 
> Diff: https://reviews.apache.org/r/32551/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message