hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 32551: HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
Date Thu, 26 Mar 2015 22:03:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32551/#review77956
-----------------------------------------------------------


It looks good Aihua except minor points below, I suppose its unfortunate that the TokenStore
init method all take in objectStore even if only one needs it.


service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java
<https://reviews.apache.org/r/32551/#comment126320>

    I think we should use .equals comparison.  Also need to get rid of the preceding space
in the if condition.


Also please remove the extra whitespace.

- Szehon Ho


On March 26, 2015, 9:55 p.m., Aihua Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32551/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 9:55 p.m.)
> 
> 
> Review request for hive and Szehon Ho.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-10093 Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
> 
> 
> Diffs
> -----
> 
>   itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHiveAuthFactory.java
a30ec7e9e5e079f7c13456c29082121da9b6c202 
>   service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java 22c309fbfd941fb517370057ef38fbec903ce088

> 
> Diff: https://reviews.apache.org/r/32551/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aihua Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message