hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 32374: HIVE-1575 get_json_object does not support JSON array at the root level
Date Tue, 24 Mar 2015 23:30:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32374/#review77672
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java
<https://reviews.apache.org/r/32374/#comment125843>

    I don't know anything about JsonPath - so "$[0]", "[0]", "$.[0]" are all valid JsonPath?
Should the path string always start with $ to be consistent with the rest of the syntax?


- Jason Dere


On March 22, 2015, 6:07 a.m., Alexander Pivovarov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32374/
> -----------------------------------------------------------
> 
> (Updated March 22, 2015, 6:07 a.m.)
> 
> 
> Review request for hive, Jason Dere and namit jain.
> 
> 
> Bugs: HIVE-1575
>     https://issues.apache.org/jira/browse/HIVE-1575
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-1575 get_json_object does not support JSON array at the root level
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/UDFJson.java 781286613d1b939f684e7be95341adaeeca0c60e

>   ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFJson.java PRE-CREATION 
>   ql/src/test/queries/clientpositive/udf_get_json_object.q 05f7f5a9811bc028565d88f08fc36058cd85148d

>   ql/src/test/results/clientpositive/udf_get_json_object.q.out 51f0c1510d101189e281f40ffd7bcd7f1ed97c84

> 
> Diff: https://reviews.apache.org/r/32374/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message