hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaoyu Tang" <ctang...@gmail.com>
Subject Review Request 32190: HIVE-9975:Renaming a nonexisting partition should not throw out NullPointerException
Date Wed, 18 Mar 2015 02:09:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32190/
-----------------------------------------------------------

Review request for hive, Szehon Ho and Xuefu Zhang.


Bugs: HIVE-9975
    https://issues.apache.org/jira/browse/HIVE-9975


Repository: hive-git


Description
-------

Currently Hive throws out NullPointerException when it renames a partition which does not
exist. It is not proper and user unfriendly. 
This patch is going to change Hive to throw out HiveException with more informative error
message: "Rename partition: source partition [pcol1=nonexist_part1/pcol2=nonexist_part2] does
not exist."


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d634b4021600fd8b980dc5d56b77e3192eba5d9f

  ql/src/test/queries/clientnegative/alter_rename_partition_failure.q be971f18498693491d0699f7793a39e21b1ed684

  ql/src/test/results/clientnegative/alter_rename_partition_failure.q.out f1640be1d2728d971517afdfc4f36efe1e5bb508


Diff: https://reviews.apache.org/r/32190/diff/


Testing
-------

1. Manaully tests passed
2. Precommit tests


Thanks,

Chaoyu Tang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message