hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Pivovarov" <apivova...@gmail.com>
Subject Re: Review Request 31771: HIVE-9857 Create Factorial UDF
Date Wed, 11 Mar 2015 00:37:26 GMT


> On March 10, 2015, 6:22 p.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFactorial.java, line
72
> > <https://reviews.apache.org/r/31771/diff/1/?file=886070#file886070line72>
> >
> >     Which version of commons-math do we use in Hive? Looks like ArithmeticUtils.factorial()
has been deprecated in favor of CombinatoricsUtils.factorial().

CombinatoricsUtils appeared in commons-math3-3.3
hive-ecec has transitive dependency to commons-math3-3.1.1.jar  (from org.apache.spark:spark-core_2.10:jar:1.2.0:compile)

hive/lib dir contains only commons-math-2.1.jar
ArithmeticUtils can be found in hive/lib/hive-jdbc-1.2.0-SNAPSHOT-standalone.jar

ArithmeticUtils existed in math3 from the beginning from common-math3-3.0
http://commons.apache.org/proper/commons-math/javadocs/api-3.0/index.html

Looks like commons-math-2.1.jar does not have factorial() implementation

hive projects pom.xml do not have direct commons-math or commons-math3 dependency


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31771/#review75918
-----------------------------------------------------------


On March 5, 2015, 7:46 p.m., Alexander Pivovarov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31771/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 7:46 p.m.)
> 
> 
> Review request for hive and Jason Dere.
> 
> 
> Bugs: HIVE-9857
>     https://issues.apache.org/jira/browse/HIVE-9857
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-9857 Create Factorial UDF
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 20811abba06c0c08751c57adad854a377abc300e

>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFactorial.java PRE-CREATION

>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFactorial.java PRE-CREATION

>   ql/src/test/queries/clientpositive/udf_factorial.q PRE-CREATION 
>   ql/src/test/results/clientpositive/show_functions.q.out f2bec4785dbc110f64b1b2820c6a52f3f2a369a7

>   ql/src/test/results/clientpositive/udf_factorial.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31771/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Pivovarov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message