hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From j.prasant...@gmail.com
Subject Re: Review Request 31386: HIVE-9555 assorted ORC refactorings for LLAP on trunk
Date Tue, 10 Mar 2015 18:34:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31386/#review75904
-----------------------------------------------------------



common/src/java/org/apache/hadoop/hive/common/DiskRange.java
<https://reviews.apache.org/r/31386/#comment123230>

    does not override hashcode.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123236>

    Can you remove the fileName? We don't really need it except for logging. HIVE-9841 logs
the fileName at high level whenever exception is thrown.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123237>

    Same here. I don't think we make use of fileName anywhere.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java
<https://reviews.apache.org/r/31386/#comment123239>

    Same here.



ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java
<https://reviews.apache.org/r/31386/#comment123242>

    nit: Implement AutoCloseable? Since we moved to JDK7 we can make use of try-with-resources



ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java
<https://reviews.apache.org/r/31386/#comment123249>

    Why does it return 0? Is it a bug in HDFS?


- Prasanth_J


On Feb. 24, 2015, 11:35 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31386/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 11:35 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/DiskRange.java PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/common/DiskRangeList.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/CompressionCodec.java 5e2d880 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 62c6f8d 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/MetadataReader.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFile.java 25bb15a 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 498ee14 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/PositionProvider.java 3daa9ba 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/Reader.java f85c21b 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java 03f8085 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 2745bee 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderUtils.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReaderV2.java 4057036

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 23e5f27

>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java cb7c103 
>   ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java f4a2e65 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInStream.java 0ea4a7b 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 2cc3d7a 
>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestIntegerCompressionReader.java 591ec3f

>   ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java 326dde4 
> 
> Diff: https://reviews.apache.org/r/31386/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message