hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 31759: HIVE-9620: Cannot retrieve column statistics using HMS API if column name contains uppercase characters
Date Thu, 05 Mar 2015 03:44:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31759/#review75287
-----------------------------------------------------------

Ship it!


Ship It!

- Xuefu Zhang


On March 5, 2015, 3:16 a.m., Chaoyu Tang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31759/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 3:16 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Brock Noland, Szehon Ho, and Xuefu Zhang.
> 
> 
> Bugs: HIVE-9620
>     https://issues.apache.org/jira/browse/HIVE-9620
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The identifier such as column name is stored in lowercase in metastore backend tables.
Hive usually converts these identifiers to lowercase before calling HMS APIs, but it might
not be always true. Other HMS clients like Impala might also not do that. So we need convert
the identifiers in HMS request to lowercase in HiveMetaStore.java before querying backend
tables. Some existing APIs in HiveMetaStore have already done this conversion but others have
not, especially those APIs for Statistics with StatsRequest. This patch is going to change
all these identifiers passed in StatRequest to lowercase before querying backend tables.
> 
> 
> Diffs
> -----
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 379abaf3cd883163e6b94c86f35c501024c98150

> 
> Diff: https://reviews.apache.org/r/31759/diff/
> 
> 
> Testing
> -------
> 
> PreCommit tests passed: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2946/testReport
> 
> 
> Thanks,
> 
> Chaoyu Tang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message