Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87694101F9 for ; Fri, 13 Feb 2015 18:43:18 +0000 (UTC) Received: (qmail 88922 invoked by uid 500); 13 Feb 2015 18:43:12 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 88828 invoked by uid 500); 13 Feb 2015 18:43:12 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 88816 invoked by uid 500); 13 Feb 2015 18:43:11 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 88813 invoked by uid 99); 13 Feb 2015 18:43:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Feb 2015 18:43:11 +0000 Date: Fri, 13 Feb 2015 18:43:11 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-9605) Remove parquet nested objects from wrapper writable objects MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-9605?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Brock Noland updated HIVE-9605: ------------------------------- Resolution: Fixed Fix Version/s: parquet-branch Status: Resolved (was: Patch Available) Committed to branch! > Remove parquet nested objects from wrapper writable objects > ----------------------------------------------------------- > > Key: HIVE-9605 > URL: https://issues.apache.org/jira/browse/HIVE-9605 > Project: Hive > Issue Type: Sub-task > Affects Versions: 0.14.0 > Reporter: Sergio Pe=C3=B1a > Assignee: Sergio Pe=C3=B1a > Fix For: parquet-branch > > Attachments: HIVE-9605.3.patch, HIVE-9605.4.patch > > > Parquet nested types are using an extra wrapper object (ArrayWritable) as= a wrapper of map and list elements. This extra object is not needed and ca= using unnecessary memory allocations. > An example of code is on HiveCollectionConverter.java: > {noformat} > public void end() { > parent.set(index, wrapList(new ArrayWritable( > Writable.class, list.toArray(new Writable[list.size()])))); > } > {noformat} > This object is later unwrapped on AbstractParquetMapInspector, i.e.: > {noformat} > final Writable[] mapContainer =3D ((ArrayWritable) data).get(); > final Writable[] mapArray =3D ((ArrayWritable) mapContainer[0]).get(); > for (final Writable obj : mapArray) { > ... > } > {noformat} > We should get rid of this wrapper object to save time and memory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)