Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1989A17C12 for ; Tue, 24 Feb 2015 23:29:47 +0000 (UTC) Received: (qmail 95093 invoked by uid 500); 24 Feb 2015 23:29:37 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 95020 invoked by uid 500); 24 Feb 2015 23:29:37 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 95004 invoked by uid 99); 24 Feb 2015 23:29:37 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Feb 2015 23:29:37 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 723D91D3185; Tue, 24 Feb 2015 23:29:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3822236645385552507==" MIME-Version: 1.0 Subject: Re: Review Request 30717: HIVE-8119: Implement Date in ParquetSerde From: "Ryan Blue" To: "Dong Chen" , "hive" , "Ryan Blue" Date: Tue, 24 Feb 2015 23:29:34 -0000 Message-ID: <20150224232934.4174.9667@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ryan Blue" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30717/ X-Sender: "Ryan Blue" References: <20150206075114.1285.43536@reviews.apache.org> In-Reply-To: <20150206075114.1285.43536@reviews.apache.org> Reply-To: "Ryan Blue" X-ReviewRequest-Repository: hive-git --===============3822236645385552507== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30717/#review73933 ----------------------------------------------------------- Ship it! Ship It! - Ryan Blue On Feb. 5, 2015, 11:51 p.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30717/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 11:51 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-8119: Implement Date in ParquetSerde > > This patch map the Date in Hive to INT32 in Parquet, based on the Parquet Logical Type Definitions in https://github.com/apache/incubator-parquet-format/blob/master/LogicalTypes.md > > > Diffs > ----- > > data/files/parquet_types.txt 31a10c9 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ETypeConverter.java 377e362 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveSchemaConverter.java e5bd70c > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ArrayWritableObjectInspector.java bb066af > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java 9199127 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java 1d83bf3 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestHiveSchemaConverter.java f232c57 > ql/src/test/queries/clientnegative/parquet_date.q 89d3602 > ql/src/test/queries/clientpositive/parquet_types.q 806db24 > ql/src/test/results/clientnegative/parquet_date.q.out d1c38d6 > ql/src/test/results/clientpositive/parquet_types.q.out dc5ceb0 > > Diff: https://reviews.apache.org/r/30717/diff/ > > > Testing > ------- > > UT passed. 2 tests are added > > > Thanks, > > Dong Chen > > --===============3822236645385552507==--