Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7C0AB17727 for ; Tue, 17 Feb 2015 18:19:00 +0000 (UTC) Received: (qmail 27697 invoked by uid 500); 17 Feb 2015 18:19:00 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 27628 invoked by uid 500); 17 Feb 2015 18:19:00 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 27612 invoked by uid 99); 17 Feb 2015 18:18:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Feb 2015 18:18:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8C6311CF888; Tue, 17 Feb 2015 18:18:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8071870968854053559==" MIME-Version: 1.0 Subject: Re: Review Request 30437: Implement MONTHS_BETWEEN aligned with Oracle one From: "Alexander Pivovarov" To: "Alexander Pivovarov" , "XIAOBING ZHOU" , "hive" Date: Tue, 17 Feb 2015 18:18:58 -0000 Message-ID: <20150217181858.21353.81147@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alexander Pivovarov" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30437/ X-Sender: "Alexander Pivovarov" References: <20150204223025.1286.51013@reviews.apache.org> In-Reply-To: <20150204223025.1286.51013@reviews.apache.org> Reply-To: "Alexander Pivovarov" X-ReviewRequest-Repository: hive-git --===============8071870968854053559== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30437/#review72744 ----------------------------------------------------------- ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java Because you modified GenericUDFDateDiff can you also add tests to udf_datediff.q to make sure it works. Currently udf_datediff.q has just two desc datediff lines - Alexander Pivovarov On Feb. 4, 2015, 10:30 p.m., XIAOBING ZHOU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30437/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 10:30 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is used to track work to build Oracle like months_between. Here's semantics: > MONTHS_BETWEEN returns number of months between dates date1 and date2. If date1 is later than date2, then the result is positive. If date1 is earlier than date2, then the result is negative. If date1 and date2 are either the same days of the month or both last days of months, then the result is always an integer. Otherwise Oracle Database calculates the fractional portion of the result based on a 31-day month and considers the difference in time components date1 and date2. > > https://issues.apache.org/jira/browse/HIVE-9518 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java bfb4dc2 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java 1ecd835 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiffBase.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFMonthsBetween.java PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error1.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error2.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error3.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error4.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error5.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error6.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error7.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error8.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_months_between_error9.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_months_between.q PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error1.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error2.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error3.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error4.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error5.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error6.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error7.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error8.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_months_between_error9.q.out PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out e21b54b > ql/src/test/results/clientpositive/udf_months_between.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/30437/diff/ > > > Testing > ------- > > SEE ALSO ql/src/test/TestGenericUDFMonthsBetween.java > > > Thanks, > > XIAOBING ZHOU > > --===============8071870968854053559==--