Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============3619718278787619346=="
MIME-Version: 1.0
Subject: Re: Review Request 26854: HIVE-2573 Create per-session function
 registry
From: "Navis Ryu" <navis.ryu@nexr.com>
To: "Navis Ryu" <navis.ryu@nexr.com>, "Thejas Nair" <thejas@hortonworks.com>
Cc: "Alexander Pivovarov" <apivovarov@gmail.com>,
 "Jason Dere" <jdere@hortonworks.com>, "hive" <dev@hive.apache.org>
Date: Thu, 12 Feb 2015 01:55:04 -0000
Message-ID: <20150212015504.29076.768@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Navis Ryu" <noreply@reviews.apache.org>
References: <20150211004944.29075.61262@reviews.apache.org>
In-Reply-To: <20150211004944.29075.61262@reviews.apache.org>
Reply-To: "Navis Ryu" <navis.ryu@nexr.com>

--===============3619718278787619346==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 11, 2015, 12:49 a.m., Alexander Pivovarov wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 341
> > <https://reviews.apache.org/r/26854/diff/7/?file=858817#file858817line341>
> >
> >     What you think about adding 2 static wrapper methods registerUDF and registerGenericUDF and use old code (without "system." prefix)

Is it necessary? It's clarifying where the function is added to.


- Navis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26854/#review71893
-----------------------------------------------------------


On Feb. 9, 2015, 6:56 p.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26854/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 6:56 p.m.)
> 
> 
> Review request for hive, Navis Ryu and Thejas Nair.
> 
> 
> Bugs: HIVE-2573
>     https://issues.apache.org/jira/browse/HIVE-2573
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Small updates to Navis' changes:
> - session registry doesn't lookup metastore for UDFs
> - my feedback from Navis' original patch
> - metastore udfs should not be considered native. This allows them to be added/removed from registry
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/JavaUtils.java 9aa917c 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8885fd3 
>   contrib/src/test/results/clientnegative/invalid_row_sequence.q.out 8f3c0b3 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 5f28d73 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java a06e858 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java bd00bd4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 29fc99b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 7d72783 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java 3a2a6ee 
>   ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java a29601c 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4aac39a 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Partition.java f8007e1 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 69a4545 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/IndexUtils.java 2729ceb 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java c8c5369 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 6a319b7 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 1ef6d1b 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 20c73cd 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 9c7603c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g bbb8eb3 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IndexUpdater.java 2b239ab 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 9397b7d 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 28afc6b 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/FunctionWork.java f968bc1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/ReloadFunctionDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 14bc46a 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java 903a9b0 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 46f8052 
>   ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb 
>   ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out c7405ed 
>   ql/src/test/results/clientnegative/create_function_nonudf_class.q.out d0dd50a 
>   ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5 
>   ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out ec981ee 
> 
> Diff: https://reviews.apache.org/r/26854/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


--===============3619718278787619346==--