Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 465BB10E6A for ; Wed, 11 Feb 2015 23:56:19 +0000 (UTC) Received: (qmail 16385 invoked by uid 500); 11 Feb 2015 23:56:18 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 16318 invoked by uid 500); 11 Feb 2015 23:56:18 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 16298 invoked by uid 99); 11 Feb 2015 23:56:18 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Feb 2015 23:56:18 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9D4D11CF8E4; Wed, 11 Feb 2015 23:56:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3000012260370043418==" MIME-Version: 1.0 Subject: Re: Review Request 30750: HIVE-9605 Remove parquet nested objects from wrapper writable objects From: "Ryan Blue" To: "cheng xu" , "Dong Chen" , "Ryan Blue" Cc: "hive" , "Sergio Pena" Date: Wed, 11 Feb 2015 23:56:17 -0000 Message-ID: <20150211235617.11124.94378@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ryan Blue" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30750/ X-Sender: "Ryan Blue" References: <20150211235108.29075.10990@reviews.apache.org> In-Reply-To: <20150211235108.29075.10990@reviews.apache.org> Reply-To: "Ryan Blue" X-ReviewRequest-Repository: hive-git --===============3000012260370043418== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30750/#review72067 ----------------------------------------------------------- Ship it! Ship It! - Ryan Blue On Feb. 11, 2015, 3:51 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30750/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2015, 3:51 p.m.) > > > Review request for hive, Ryan Blue, cheng xu, and Dong Chen. > > > Bugs: HIVE-9605 > https://issues.apache.org/jira/browse/HIVE-9605 > > > Repository: hive-git > > > Description > ------- > > Remove wrapper object from parquet nested types (map/array) > > > Diffs > ----- > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java 61c2eb418e4ad317a603e87240295f9396d1d5b5 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveCollectionConverter.java 6621a8768953a9bef54e7a144ae045abcc32f458 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/HiveGroupConverter.java 4809f9b5882ae409159b422c08c665aa24f796d8 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/Repeated.java fdea782167d63593f6cbde5e7154d771761757f7 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/AbstractParquetMapInspector.java 62c61fc7502f24e6a032076f384b5a946c1cc9a6 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/DeepParquetHiveMapInspector.java d38c64192e01371c0c98b339113348d2e52cedc3 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveArrayInspector.java 53ca31d0b516c4a941e048e98e7f8f763752c436 > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/StandardParquetHiveMapInspector.java 5aa14482899fed5711b40c5554b056d07818afb5 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestArrayCompatibility.java f7f3e57c1607dec3e8dc3a29e819d3aadc65155a > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestMapStructures.java ca4805082fd717d15ed41ca15a730e19da267c8a > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 007a665529857bcec612f638a157aa5043562a15 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestAbstractParquetMapInspector.java ef05150494027ddd70790dcf26b772ebc4cd2b8b > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestDeepParquetHiveMapInspector.java 8646ff4d3413d7d642e2559e1a485d77472b156a > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveArrayInspector.java f3a24af2e5f4eeb24e1e286ada19fc9592daacb6 > ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestStandardParquetHiveMapInspector.java 278419f73b311322dcf3c70abb340bf63d8a4337 > > Diff: https://reviews.apache.org/r/30750/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > > --===============3000012260370043418==--