Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5490C10579 for ; Mon, 9 Feb 2015 19:01:15 +0000 (UTC) Received: (qmail 26253 invoked by uid 500); 9 Feb 2015 19:01:15 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 26179 invoked by uid 500); 9 Feb 2015 19:01:15 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 26162 invoked by uid 99); 9 Feb 2015 19:01:14 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 19:01:14 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4951C1CE09E; Mon, 9 Feb 2015 19:01:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0777453830046934150==" MIME-Version: 1.0 Subject: Re: Review Request 30739: HIVE-9574 Lazy computing in HiveBaseFunctionResultList may hurt performance [Spark Branch] From: "Jimmy Xiang" To: "Xuefu Zhang" , "Rui Li" Cc: "Jimmy Xiang" , "hive" Date: Mon, 09 Feb 2015 19:01:14 -0000 Message-ID: <20150209190114.29075.60238@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jimmy Xiang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30739/ X-Sender: "Jimmy Xiang" References: <20150209031748.29075.65327@reviews.apache.org> In-Reply-To: <20150209031748.29075.65327@reviews.apache.org> Reply-To: "Jimmy Xiang" X-ReviewRequest-Repository: hive-git --===============0777453830046934150== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 9, 2015, 3:17 a.m., Rui Li wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.java, line 102 > > > > > > What happens if input!=null and we're creating the temp file again? Right. We use a new temp file since the old one is still in use. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30739/#review71604 ----------------------------------------------------------- On Feb. 7, 2015, 3:09 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30739/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2015, 3:09 a.m.) > > > Review request for hive, Rui Li and Xuefu Zhang. > > > Bugs: HIVE-9574 > https://issues.apache.org/jira/browse/HIVE-9574 > > > Repository: hive-git > > > Description > ------- > > Result KV cache doesn't use RowContainer any more since it has logic we don't need, which is some overhead. We don't do lazy computing right away, instead we wait a little till the cache is close to spill. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveBaseFunctionResultList.java 78ab680 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveKVResultCache.java 8ead0cb > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 7a09b4d > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java e92e299 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 070ea4d > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunctionResultList.java d4ff37c > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/KryoSerializer.java 286816b > ql/src/test/org/apache/hadoop/hive/ql/exec/spark/TestHiveKVResultCache.java 0df4598 > > Diff: https://reviews.apache.org/r/30739/diff/ > > > Testing > ------- > > Unit test, test on cluster > > > Thanks, > > Jimmy Xiang > > --===============0777453830046934150==--