Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B42E177E8 for ; Wed, 4 Feb 2015 01:30:19 +0000 (UTC) Received: (qmail 77979 invoked by uid 500); 4 Feb 2015 01:30:20 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 77907 invoked by uid 500); 4 Feb 2015 01:30:20 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 77853 invoked by uid 99); 4 Feb 2015 01:30:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 01:30:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0A1CE1CC3D6; Wed, 4 Feb 2015 01:30:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4914833157664087227==" MIME-Version: 1.0 Subject: Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer implementations to filter out results of 'show tables', 'show databases' From: "Thejas Nair" To: "Jason Dere" Cc: "Thejas Nair" , "hive" Date: Wed, 04 Feb 2015 01:30:23 -0000 Message-ID: <20150204013023.30543.19916@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30575/ X-Sender: "Thejas Nair" References: <20150203192716.32500.55194@reviews.apache.org> In-Reply-To: <20150203192716.32500.55194@reviews.apache.org> Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============4914833157664087227== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30575/ ----------------------------------------------------------- (Updated Feb. 4, 2015, 1:30 a.m.) Review request for hive and Jason Dere. Changes ------- HIVE-9350.4.patch - addressing review comments from Jason Bugs: HIVE-9350 https://issues.apache.org/jira/browse/HIVE-9350 Repository: hive-git Description ------- https://issues.apache.org/jira/browse/HIVE-9350 Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93 itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b Diff: https://reviews.apache.org/r/30575/diff/ Testing ------- New unit tests. Thanks, Thejas Nair --===============4914833157664087227==--