Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DEA44179C1 for ; Tue, 3 Feb 2015 20:42:56 +0000 (UTC) Received: (qmail 3693 invoked by uid 500); 3 Feb 2015 20:42:57 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 3625 invoked by uid 500); 3 Feb 2015 20:42:57 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 3601 invoked by uid 99); 3 Feb 2015 20:42:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Feb 2015 20:42:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 904641CC37B; Tue, 3 Feb 2015 20:43:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0839294381780769577==" MIME-Version: 1.0 Subject: Re: Review Request 30254: HIVE-9444 From: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= To: "John Pullokkaran" Cc: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= , hive Date: Tue, 03 Feb 2015 20:43:00 -0000 Message-ID: <20150203204300.32500.57680@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/30254/ X-Sender: =?utf-8?b?Ikplc8O6cyBDYW1hY2hvIFJvZHLDrWd1ZXoiIDxub3JlcGx5QHJldmlld3Mu?= =?utf-8?q?apache=2Eorg=3E?= References: <20150203202503.32500.51254@reviews.apache.org> In-Reply-To: <20150203202503.32500.51254@reviews.apache.org> Reply-To: =?utf-8?q?Jes=C3=BAs_Camacho_Rodr=C3=ADguez?= X-ReviewRequest-Repository: hive-git --===============0839294381780769577== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Feb. 3, 2015, 8:25 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java, line 175 > > > > > > What happens when you have more than one operator for the given class? wouldn't it overwrite the old value? It is a multimap, so it will have a list of values (in this case operators) for every key (in this case, classes). - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70820 ----------------------------------------------------------- On Feb. 3, 2015, 7:51 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30254/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 7:51 p.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-9444 > https://issues.apache.org/jira/browse/HIVE-9444 > > > Repository: hive-git > > > Description > ------- > > HIVE-9444 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java 4d9d1da77394125cfcb9ac9ccf1c00528664b981 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java c9848dacd1a02db321583c2b91eb6d7317c295ff > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java f031b281ff64706cdbbc1695a6f51282127487fa > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 43f8321107304c38ecd9f603cd3f8ce43e8496c8 > > Diff: https://reviews.apache.org/r/30254/diff/ > > > Testing > ------- > > Existing tests (global_limit.q). > > > Thanks, > > Jesús Camacho Rodríguez > > --===============0839294381780769577==--