Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E200810094 for ; Sun, 1 Feb 2015 07:52:42 +0000 (UTC) Received: (qmail 64867 invoked by uid 500); 1 Feb 2015 07:52:43 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 64790 invoked by uid 500); 1 Feb 2015 07:52:43 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 64775 invoked by uid 99); 1 Feb 2015 07:52:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Feb 2015 07:52:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7B4A11CAC22; Sun, 1 Feb 2015 07:52:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0924543764070629528==" MIME-Version: 1.0 Subject: Re: Review Request 29807: HIVE-9253: MetaStore server should support timeout for long running requests From: "Lefty Leverenz" To: "Lefty Leverenz" , "Dong Chen" , "hive" Date: Sun, 01 Feb 2015 07:52:46 -0000 Message-ID: <20150201075246.30544.56458@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Lefty Leverenz" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/29807/ X-Sender: "Lefty Leverenz" References: <20150121064335.9401.59923@reviews.apache.org> In-Reply-To: <20150121064335.9401.59923@reviews.apache.org> Reply-To: "Lefty Leverenz" X-ReviewRequest-Repository: hive-git --===============0924543764070629528== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 20, 2015, 10:43 p.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 372-374 > > > > > > Shouldn't "long" & "LONG" be included in the names "hive.metastore.server.running.method.timeout" & "METASTORE_SERVER_RUNNING_METHOD_TIMEOUT"? > > > > Also, please specify the JIRA number (HIVE-9253) in this review request, either under Bugs in the Information section or in the Summary, or both. > > Dong Chen wrote: > Thanks for your review and suggestion! Lefty. > I have renamed it in the new patch. Thanks very much. - Lefty ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review68878 ----------------------------------------------------------- On Jan. 28, 2015, 12:58 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 12:58 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9253: MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 66f436b > metastore/src/java/org/apache/hadoop/hive/metastore/Deadline.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/DeadlineException.java PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java fc6f067 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 574141c > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java 01ad36a > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestDeadline.java PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > > --===============0924543764070629528==--