hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9690) Refactoring for non-numeric arithmetic operations
Date Sat, 14 Feb 2015 21:52:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321723#comment-14321723
] 

Jason Dere commented on HIVE-9690:
----------------------------------

Looks like RexNodeConverter (used for passing the parsed query to Calcite) is using the UDF
class to make some assumptions about the UDF return type, which might be what is causing the
test failures. There is probably a better way to get this information.

> Refactoring for non-numeric arithmetic operations
> -------------------------------------------------
>
>                 Key: HIVE-9690
>                 URL: https://issues.apache.org/jira/browse/HIVE-9690
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-9690.1.patch
>
>
> Some refactoring for HIVE-5021. The current arithmetic UDFs are specialized for numeric
types, and trying to change the logic in the existing UDFs looks a bit complicated. A less
intrusive fix would be to create the date-time/interval arithmetic UDFs as a separate UDF
class, and to make the plus/minus UDFs act as a wrapper which would invoke the numeric or
interval arithmetic UDF depending on the args.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message