hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9619) Uninitialized read of numBitVectors in NumDistinctValueEstimator
Date Sat, 14 Feb 2015 00:46:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321057#comment-14321057
] 

Gopal V commented on HIVE-9619:
-------------------------------

LGTM - +1.

Left a minor comment on the RB, but it is not related to any changes, but just as a note.

> Uninitialized read of numBitVectors in NumDistinctValueEstimator
> ----------------------------------------------------------------
>
>                 Key: HIVE-9619
>                 URL: https://issues.apache.org/jira/browse/HIVE-9619
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-9619.1.patch, HIVE-9619.2.patch
>
>
> {code}
>   private int numBitVectors;
>   // Refer to Flajolet-Martin'86 for the value of phi
>   private final double phi =  0.77351;
>   private int[] a;
>   private int[] b;
>   // Uninitialized read of numBitVectors
>   private  FastBitSet[] bitVector = new FastBitSet[numBitVectors];
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message