hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9322) Make null-checks consistent for MapObjectInspector subclasses.
Date Fri, 20 Feb 2015 18:26:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14329314#comment-14329314
] 

Ashutosh Chauhan commented on HIVE-9322:
----------------------------------------

 This alters the semantics by allowing to have null keys in map which were disallowed earlier.
[~mithun], I remember we had similar discussion previously about null-keys-in-map I forgot
which ticket was it and what we decided. If you remember, can you point me to that ticket.
Just want to make sure we are consistent with our earlier decision.

Also as a side note, performance wise its not free, since it adds a if-else branch in inner
most loop of parsing while reading data.

> Make null-checks consistent for MapObjectInspector subclasses.
> --------------------------------------------------------------
>
>                 Key: HIVE-9322
>                 URL: https://issues.apache.org/jira/browse/HIVE-9322
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>    Affects Versions: 0.14.0
>            Reporter: Mithun Radhakrishnan
>            Assignee: Mithun Radhakrishnan
>            Priority: Minor
>         Attachments: HIVE-9322.1.patch
>
>
> {{LazyBinaryMapObjectInspector}}, {{DeepParquetHiveMapInspector}}, etc. check both the
map-column value and the map-key for null, before dereferencing them. {{OrcMapObjectInspector}}
and {{LazyMapObjectInspector}} do not.
> This patch brings them all in sync. Might not be a real problem, unless (for example)
the lookup key is itself a (possibly null) value from another column.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message