hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-9151) Checking s against null in TezJobMonitor#getNameWithProgress() should be done earlier
Date Mon, 02 Feb 2015 19:25:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-9151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301740#comment-14301740
] 

Ashutosh Chauhan commented on HIVE-9151:
----------------------------------------

+1

> Checking s against null in TezJobMonitor#getNameWithProgress() should be done earlier
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-9151
>                 URL: https://issues.apache.org/jira/browse/HIVE-9151
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 1.2.0, 1.1.0
>            Reporter: Ted Yu
>            Assignee: Prasanth Jayachandran
>            Priority: Minor
>         Attachments: HIVE-9151.1.patch
>
>
> {code}
>     int spaceRemaining = COLUMN_1_WIDTH - s.length() - 1;
>     String trimmedVName = s;
>     // if the vertex name is longer than column 1 width, trim it down
>     // "Tez Merge File Work" will become "Tez Merge File.."
>     if (s != null && s.length() > COLUMN_1_WIDTH) {
> {code}
> s is dereferenced first, rendering the null check ineffective.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message